reporting to images #61

ThetaSinner · 2018-10-25T22:09:56Z

This is the big one, finally starting what we set out to do! :-)

Sub-Xaero · 2018-10-26T08:35:34Z

This is the big one, finally starting what we set out to do! :-)

I'm so excited!!!!

Sub-Xaero · 2018-10-29T10:45:34Z

Still no idea why codacy is doing this. Its bloody annoying.

ThetaSinner · 2018-10-29T18:36:13Z

Lol, shtaaap deleting ma codacy-bot comments ;P

I assume it's a GH bug because codacy can't do that on your behalf...

codecov-io · 2018-10-30T20:31:10Z

Codecov Report

Merging #61 into master will decrease coverage by 9.82%.
The diff coverage is 2.59%.

@@             Coverage Diff              @@
##             master      #61      +/-   ##
============================================
- Coverage      43.4%   33.57%   -9.83%     
- Complexity       61       63       +2     
============================================
  Files            66       76      +10     
  Lines           728      959     +231     
  Branches        105      123      +18     
============================================
+ Hits            316      322       +6     
- Misses          371      596     +225     
  Partials         41       41

Impacted Files	Coverage Δ	Complexity Δ
...a/acropolis/service/config/ServiceConfiguration.kt	`100% <ø> (ø)`	`0 <0> (ø)`	⬇️
...tence/api/persistence/GraphicalAssetPersistence.kt	`60% <0%> (-40%)`	`3 <0> (ø)`
...ra/acropolis/service/impl/GraphicalAssetService.kt	`75% <0%> (-10.72%)`	`0 <0> (ø)`
...lin/org/ephyra/acropolis/report/api/model/Graph.kt	`0% <0%> (ø)`	`0 <0> (?)`
...lin/org/ephyra/acropolis/shell/BootstrapCommand.kt	`0% <0%> (ø)`	`0 <0> (?)`
...ra/acropolis/report/impl/render/DiagramRenderer.kt	`0% <0%> (ø)`	`0 <0> (?)`
...ephyra/acropolis/report/impl/render/CardBuilder.kt	`0% <0%> (ø)`	`0 <0> (?)`
.../org/ephyra/acropolis/report/impl/render/Size2D.kt	`0% <0%> (ø)`	`0 <0> (?)`
.../ephyra/acropolis/report/impl/render/Position2D.kt	`0% <0%> (ø)`	`0 <0> (?)`
...yra/acropolis/report/config/ReportConfiguration.kt	`100% <100%> (ø)`	`1 <1> (?)`
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffdb2ae...3406096. Read the comment docs.

Sub-Xaero · 2018-10-31T14:06:18Z

Lol, shtaaap deleting ma codacy-bot comments ;P

I assume it's a GH bug because codacy can't do that on your behalf...

😆 Well, I've just blatted the Comment integration and it hasnt bitched about your latest commits, despite there being a missing comment in 548989c, so it hopefully is fixed. .

No comments at all is better than 200 deleted ones 🤷‍♂️

#19 create report service

daaec55

ThetaSinner added 2 commits October 26, 2018 17:44

#19 Create report module and define data model

a4bd706

#19 create initial helper for rendering diagrams using java2d

0e41d77

EphyraSoftware deleted a comment Oct 27, 2018

#19 Demonstrate how to draw an arrow between two images

abc7fd3

EphyraSoftware deleted a comment Oct 27, 2018

#19 display text

2d5a2d2

EphyraSoftware deleted a comment Oct 27, 2018

#19 start working on the layout process

89e70d7

ThetaSinner added 3 commits October 29, 2018 19:56

#19 calculate tile positions

7797d6f

#19 Give the report service access to the graphical asset service

548989c

#19 fix detekt issues and add docs

f01f3f8

ThetaSinner added 10 commits November 10, 2018 22:03

#19 Draw images onto the report

5ab3d48

#19 Create default images for software specializations

eaea754

#19 create application and system graphics and bootstrap command

37e0e29

#19 Bug fix for depth counts and export after report run

5b3efe9

#19 Fixes for positioning

0e79762

#19 Start on card builder for rendering images with text

d4839ea

#19 draw images and text from the card builder

8453b26

#19 Add missing doc comments for classes in the render package

02632c7

#19 Improve layout for columns in rendering

9b1fa61

#19 Fixing detect issues

3406096

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reporting to images #61

reporting to images #61

ThetaSinner commented Oct 25, 2018

Sub-Xaero commented Oct 26, 2018

Sub-Xaero commented Oct 29, 2018

ThetaSinner commented Oct 29, 2018 •

edited

Loading

codecov-io commented Oct 30, 2018 •

edited

Loading

Sub-Xaero commented Oct 31, 2018 •

edited

Loading

reporting to images #61

Are you sure you want to change the base?

reporting to images #61

Conversation

ThetaSinner commented Oct 25, 2018

Sub-Xaero commented Oct 26, 2018

Sub-Xaero commented Oct 29, 2018

ThetaSinner commented Oct 29, 2018 • edited Loading

codecov-io commented Oct 30, 2018 • edited Loading

Codecov Report

Sub-Xaero commented Oct 31, 2018 • edited Loading

ThetaSinner commented Oct 29, 2018 •

edited

Loading

codecov-io commented Oct 30, 2018 •

edited

Loading

Sub-Xaero commented Oct 31, 2018 •

edited

Loading